Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The cancel button of the delete dialog on a detail view returns to an empty document #2253

Closed
Garfield-fr opened this issue Jul 30, 2021 · 0 comments
Closed

The cancel button of the delete dialog on a detail view returns to an empty document #2253

Garfield-fr opened this issue Jul 30, 2021 · 0 comments
Labels
bug Breaks something but is not blocking developers From a developer point of view. p-Medium Medium priority (to be solved within 1-2 years)

Comments

@Garfield-fr
Copy link
Contributor

Garfield-fr commented Jul 30, 2021 •
edited
Loading

Describe the issue

When we want to delete the resource and we press the delete button and then we decide to cancel the action, it has the effect of returning to a bad url. We lose the resource display

What should be done

When we click on the cancel button, the resource should not disappear. The url should not change.

Context
version: 1.4.6
@Garfield-fr Garfield-fr added developers From a developer point of view. triage bug Breaks something but is not blocking labels Jul 30, 2021
@pronguen pronguen added p-Medium Medium priority (to be solved within 1-2 years) and removed triage labels Jul 30, 2021
Garfield-fr added a commit to Garfield-fr/ng-core that referenced this issue Aug 5, 2021
@Garfield-fr
configuration: add action parameter on redirectUrl
4d969e3 
* Adds new parameter action on redirectUrl function.
* Removes the redirection to the cancel action from the confirmation dialog.
* Closes rero/rero-ils#2253.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Aug 5, 2021
@Garfield-fr
holdings: customize the delete message
20aafb1 
* Closes rero/rero-ils#2253.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr added a commit to Garfield-fr/rero-ils-ui that referenced this issue Aug 5, 2021
@Garfield-fr
holdings: customize the delete message
cbcc97f 
* Closes rero/rero-ils#2253.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
jma pushed a commit to Garfield-fr/rero-ils-ui that referenced this issue Aug 11, 2021
@Garfield-fr @jma
holdings: customize the delete message
ab1dcdb 
* Closes rero/rero-ils#2253.
* Uses ng-core v1.13.1.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
jma pushed a commit to Garfield-fr/rero-ils-ui that referenced this issue Aug 11, 2021
@Garfield-fr @jma
holdings: customize the delete message
de3154f 
* Closes rero/rero-ils#2253.
* Uses ng-core v1.13.2.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
jma pushed a commit to rero/rero-ils-ui that referenced this issue Aug 12, 2021
@Garfield-fr @jma
holdings: customize the delete message
874a532 
* Closes rero/rero-ils#2253.
* Uses ng-core v1.13.2.

Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Breaks something but is not blocking developers From a developer point of view. p-Medium Medium priority (to be solved within 1-2 years)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Garfield-fr @pronguen