bootstrap: fix useless tgz file installation #857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zannkukai
approved these changes
Mar 18, 2020
rerowep
reviewed
Mar 19, 2020
AoNoOokami
reviewed
Mar 20, 2020
There was a problem hiding this comment.
Be sure to apply corrections asked by @rerowep at line 61 (bootstrap)
While using bootstrap script, it attempts to install TGZ_FILE. Something like `[INFO]: Install RERO-ILS-UI from tgz: ` appears. But no file were given. * Fixes rero#856 - by changing `[` tests to `[[` (bash) * Fixes boostrap script wrong parameters (delete `s` and `b`) Co-Authored-by: Olivier DOSSMANN <git@dossmann.net>
blankoworld
force-pushed
the
doo-#1380-bootstrap-tgz-file
branch
from
534fb56
to
a57fae1
Compare
rerowep
approved these changes
Mar 20, 2020
AoNoOokami
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using bootstrap script, it attempts to install TGZ_FILE.
Something like
[INFO]: Install RERO-ILS-UI from tgz:appears. But nofile were given.
[tests to[[(bash)Co-Authored-by: Olivier DOSSMANN git@dossmann.net
Why are you opening this PR?
Because of #856 issue.
How to test?
Launch
pipenv run bootstrapand check that no[INFO]: Install RERO-ILS-UI from tgz:appears.Then do the same with a TGZ file, for example those from https://github.com/rero/rero-ils-ui/releases/tag/v0.0.12, like :
pipenv run bootstrap -t v0.0.12.tar.gzCode review check list