Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organisations: search route #86

Merged
merged 1 commit into from
Jun 17, 2020
Merged

organisations: search route #86

merged 1 commit into from
Jun 17, 2020

Conversation

sebdeleze
Copy link
Contributor

@sebdeleze sebdeleze commented May 29, 2020

  • Uses one route for all organisations search page.
  • Updates route data according to the view parameter.
  • Adds the values for isShared and isDedicated properties in organisation's detail view.
  • Hides aggregation for organisation if the view code is not global.

Co-Authored-by: Sébastien Délèze sebastien.deleze@rero.ch

How to test

See rero/sonar#234

* Uses one route for all organisations search page.
* Updates route data according to the `view` parameter.
* Adds the values for `isShared` and `isDedicated` properties in organisation's detail view.
* Hides aggregation for organisation if the view code is not global.

Co-Authored-by: Sébastien Délèze <sebastien.deleze@rero.ch>
@sebdeleze sebdeleze requested a review from zannkukai June 16, 2020 08:24
Copy link

@zannkukai zannkukai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little bit complex (especially to follow changes with diff coloring) but code seems good for me and my knowledges

@sebdeleze sebdeleze merged commit 8933f83 into rero:dev Jun 17, 2020
@sebdeleze sebdeleze deleted the sed-org-view branch June 17, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants