templating: Document detail #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
reviewed
Jun 25, 2019
sonar/modules/documents/static/templates/documents/search_ui/results.html
Outdated
Show resolved
Hide resolved
Garfield-fr
reviewed
Jun 25, 2019
sonar/modules/documents/static/templates/documents/search_ui/results.html
Outdated
Show resolved
Hide resolved
Garfield-fr
reviewed
Jun 25, 2019
sonar/modules/documents/static/templates/documents/search_ui/results.html
Outdated
Show resolved
Hide resolved
Garfield-fr
requested changes
Jun 25, 2019
jma
approved these changes
Jul 22, 2019
| @@ -320,14 +321,17 @@ def marc21_to_series(self, key, value): | |||
|
|
|||
|
|
|||
| @marc21tojson.over('abstracts', '^520..') | |||
| @utils.for_each_value | |||
| @utils.ignore_value | |||
| def marc21_to_abstracts(self, key, value): | |||
There was a problem hiding this comment.
@marc21tojson.over('abstracts', '^520..')
@utils.for_each_value
@utils.ignore_value
def marc21_to_abstracts(self, key, value):
lang = value.get('9')
abs = value.get('a')
abstracts = self.get('abstracts', {})
abstracts[lang] = abs
return abstracts
sonar/modules/documents/views.py
Outdated
| @@ -58,4 +60,88 @@ def search(): | |||
| def detail(pid, record, template=None, **kwargs): | |||
| """Search details.""" | |||
| g.ir = kwargs.get('ir') | |||
| return render_template('documents/record.html', pid=pid, record=record) | |||
| return render_template('documents/record.html', | |||
| pid=pid, record=record, ir=g.ir) | |||
There was a problem hiding this comment.
check if it is necessary g should be available in templates
NEW Format and show information on document detail page. Signed-off-by: Sébastien Délèze <sebastien.deleze@rero.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEW Format and show information on document detail page.
BETTER Add black support for code formatting