organisations: favicon and platform name #768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
force-pushed
the
zub-favicon-viewname
branch
5 times, most recently
from
78e2a6f
to
2b693ef
Compare
Garfield-fr
force-pushed
the
zub-favicon-viewname
branch
2 times, most recently
from
217d9be
to
35086dd
Compare
jma
approved these changes
Feb 9, 2022
sonar/config.py
Outdated
| @@ -58,6 +58,9 @@ def _(x): | |||
| return x | |||
|
|
|||
|
|
|||
| # Sonar global view name | |||
| SONAR_GLOBAL_VIEW_NAME = 'global' | |||
There was a problem hiding this comment.
Why not using SONAR_APP_DEFAULT_ORGANISATION?
sonar/ext.py
Outdated
| @app.template_filter() | ||
| def organisation_view(pid): | ||
| """Get current organisation.""" | ||
| return OrganisationRecord.get_or_create(pid) if pid else {} |
There was a problem hiding this comment.
Looks not safe. It can in some case create a new organisation, no?
sonar/ext.py
Outdated
| lambda d: d['mimetype'] == 'image/x-icon', files)) | ||
| if favicon: | ||
| file = favicon[0]['key'] | ||
| return f'/organisations/{key}/files/{file}' |
sonar/ext.py
Outdated
| key = org.get('pid') | ||
| files = org.get('_files', []) | ||
| favicon = list(filter( | ||
| lambda d: d['mimetype'] == 'image/x-icon', files)) |
There was a problem hiding this comment.
I would be better to introduce a new type of file: favicon
Garfield-fr
force-pushed
the
zub-favicon-viewname
branch
5 times, most recently
from
cd31206
to
3214bff
Compare
rerowep
approved these changes
Feb 24, 2022
|
Garfield-fr
force-pushed
the
zub-favicon-viewname
branch
3 times, most recently
from
c4071ea
to
31ac72b
Compare
mmo
approved these changes
Mar 2, 2022
Garfield-fr
force-pushed
the
zub-favicon-viewname
branch
from
31ac72b
to
9028bcc
Compare
* Adds the display of the custom favicon for current organisation. * Adds the organization's platform name to the browser tab. * Closes rero#705. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr
force-pushed
the
zub-favicon-viewname
branch
from
9028bcc
to
270bc3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
How to test
Code review check list