swisscovery: remove << and >> characters in the title when importing #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garfield-fr
force-pushed
the
zub-swisscovery-remove-chars
branch
from
267c5bd
to
b37ab86
Compare
Garfield-fr
force-pushed
the
zub-swisscovery-remove-chars
branch
2 times, most recently
from
a5299cd
to
57c552d
Compare
jma
approved these changes
Feb 22, 2022
sonar/modules/swisscovery/rest.py
Outdated
| @@ -66,8 +68,18 @@ def get_record(): | |||
|
|
|||
| record = SRUSchema().dump(record) | |||
|
|
|||
| # Remove << and >> in the title value | |||
| pattern = re.compile('<<(.+)>>', re.S) | |||
| if 'title' in record: | |||
There was a problem hiding this comment.
You can write something like:
for title in record.get('title',[]):
for mainTitle in title.get('mainTitle', []):
....| def test_title_remove_char(client, submitter): | ||
| """Test for the removal of << and >> characters in the title.""" | ||
| login_user_via_session(client, email=submitter['email']) | ||
| res = client.get(url_for('swisscovery.get_record',query='2070406237')) |
Garfield-fr
force-pushed
the
zub-swisscovery-remove-chars
branch
2 times, most recently
from
be49f15
to
ac87eb4
Compare
pronguen
approved these changes
Feb 24, 2022
rerowep
requested changes
Feb 24, 2022
sonar/modules/swisscovery/rest.py
Outdated
| @@ -66,8 +68,15 @@ def get_record(): | |||
|
|
|||
| record = SRUSchema().dump(record) | |||
|
|
|||
| # Remove << and >> in the title value | |||
There was a problem hiding this comment.
The command or function is not correct. The regexp removes all << ??? >>>!
* Closes rero#701. Co-Authored-by: Bertrand Zuchuat <bertrand.zuchuat@rero.ch>
Garfield-fr
force-pushed
the
zub-swisscovery-remove-chars
branch
from
ac87eb4
to
7cc382a
Compare
rerowep
approved these changes
Feb 24, 2022
mmo
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<<and>>characters should be removed from the title #701.Co-Authored-by: Bertrand Zuchuat bertrand.zuchuat@rero.ch
How to test?
Code review check list