Skip to content

Commit

Permalink
Indicate Mat3x3 and Mat4x4 constructors are column major (#4842)
Browse files Browse the repository at this point in the history
### What

The comments were incorrect.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4842/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4842/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4842/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4842)
- [Docs
preview](https://rerun.io/preview/c5fdfbb020e4024ba8b3cb27a20bc8f20f4b4cf1/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/c5fdfbb020e4024ba8b3cb27a20bc8f20f4b4cf1/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
  • Loading branch information
jleibs committed Jan 17, 2024
1 parent d9fdbd0 commit 495ad54
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion rerun_cpp/src/rerun/datatypes/mat3x3.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rerun_cpp/src/rerun/datatypes/mat3x3_ext.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace rerun {
columns[2].z(),
} {}

/// Construct a new 3x3 matrix from a pointer to 9 floats (in row major order).
/// Construct a new 3x3 matrix from a pointer to 9 floats (in column major order).
explicit Mat3x3(const float* elements)
: flat_columns{
elements[0],
Expand Down
2 changes: 1 addition & 1 deletion rerun_cpp/src/rerun/datatypes/mat4x4.hpp

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rerun_cpp/src/rerun/datatypes/mat4x4_ext.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ namespace rerun {
columns[3].w(),
} {}

/// Construct a new 4x4 matrix from a pointer to 16 floats (in row major order).
/// Construct a new 4x4 matrix from a pointer to 16 floats (in column major order).
explicit Mat4x4(const float* elements)
: flat_columns{
elements[0],
Expand Down

0 comments on commit 495ad54

Please sign in to comment.