Skip to content

Commit

Permalink
Revert "Fix python bridge preventing logging transforms to root child (
Browse files Browse the repository at this point in the history
…#1097)" (#1098)

This reverts commit 891a5b2.
  • Loading branch information
nikolausWest committed Feb 5, 2023
1 parent 80d3247 commit 513ffde
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions rerun_py/src/python_bridge.rs
Original file line number Diff line number Diff line change
Expand Up @@ -443,8 +443,9 @@ fn log_transform(
timeless: bool,
) -> PyResult<()> {
let entity_path = parse_entity_path(entity_path)?;
if entity_path.is_root() {
return Err(PyTypeError::new_err("Transforms are between a child entity and its parent, so the root cannot have a transform"));
if entity_path.len() == 1 {
// Stop people from logging a transform to a root-entity, such as "world" (which doesn't have a parent).
return Err(PyTypeError::new_err("Transforms are between a child entity and its parent, so root entities cannot have transforms"));
}
let mut session = global_session();
let time_point = time(timeless);
Expand Down

1 comment on commit 513ffde

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: 513ffde Previous: 80d3247 Ratio
datastore/insert/batch/rects/insert 577770 ns/iter (± 2455) 583292 ns/iter (± 2067) 0.99
datastore/latest_at/batch/rects/query 1768 ns/iter (± 5) 1781 ns/iter (± 6) 0.99
datastore/latest_at/missing_components/primary 306 ns/iter (± 0) 307 ns/iter (± 0) 1.00
datastore/latest_at/missing_components/secondaries 380 ns/iter (± 1) 380 ns/iter (± 0) 1
datastore/range/batch/rects/query 154859 ns/iter (± 411) 156875 ns/iter (± 292) 0.99
mono_points_arrow/generate_message_bundles 50956811 ns/iter (± 846471) 50868108 ns/iter (± 1218864) 1.00
mono_points_arrow/generate_messages 137610020 ns/iter (± 1321254) 137591575 ns/iter (± 1353571) 1.00
mono_points_arrow/encode_log_msg 165160509 ns/iter (± 1263062) 163606654 ns/iter (± 727978) 1.01
mono_points_arrow/encode_total 354421741 ns/iter (± 1969213) 353325589 ns/iter (± 1517888) 1.00
mono_points_arrow/decode_log_msg 183898147 ns/iter (± 955174) 185355836 ns/iter (± 994111) 0.99
mono_points_arrow/decode_message_bundles 74763783 ns/iter (± 912654) 71659315 ns/iter (± 1205726) 1.04
mono_points_arrow/decode_total 256548802 ns/iter (± 1649946) 255867143 ns/iter (± 1653272) 1.00
batch_points_arrow/generate_message_bundles 318498 ns/iter (± 897) 318395 ns/iter (± 520) 1.00
batch_points_arrow/generate_messages 6145 ns/iter (± 16) 6086 ns/iter (± 21) 1.01
batch_points_arrow/encode_log_msg 366155 ns/iter (± 1499) 359977 ns/iter (± 1120) 1.02
batch_points_arrow/encode_total 715970 ns/iter (± 4210) 707576 ns/iter (± 2454) 1.01
batch_points_arrow/decode_log_msg 348352 ns/iter (± 1066) 350686 ns/iter (± 994) 0.99
batch_points_arrow/decode_message_bundles 2067 ns/iter (± 11) 2068 ns/iter (± 9) 1.00
batch_points_arrow/decode_total 355217 ns/iter (± 1003) 353854 ns/iter (± 1259) 1.00
arrow_mono_points/insert 7027707613 ns/iter (± 20467739) 6988555874 ns/iter (± 17290443) 1.01
arrow_mono_points/query 1713386 ns/iter (± 14194) 1732719 ns/iter (± 15970) 0.99
arrow_batch_points/insert 2609538 ns/iter (± 9836) 2659913 ns/iter (± 11738) 0.98
arrow_batch_points/query 16972 ns/iter (± 96) 17046 ns/iter (± 169) 1.00
tuid/Tuid::random 34 ns/iter (± 0) 34 ns/iter (± 0) 1

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.