Skip to content

Commit

Permalink
self review
Browse files Browse the repository at this point in the history
  • Loading branch information
teh-cmc committed Apr 4, 2023
1 parent 476103f commit 65a6962
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions crates/re_log_types/src/data_table.rs
Original file line number Diff line number Diff line change
Expand Up @@ -440,8 +440,9 @@ impl DataTable {
/// * Control columns are those that drive the behavior of the storage systems.
/// They are always present, always dense, and always deserialized upon reception by the
/// server.
/// Internally, time columns are handled separately from the rest of the control columns,
/// although they are control columns in and of themselves.
/// Internally, time columns are (de)serialized separately from the rest of the control
/// columns for efficiency/QOL concerns: that doesn't change the fact that they are control
/// columns all the same!
/// * Data columns are the one that hold component data.
/// They are optional, potentially sparse, and never deserialized on the server-side (not by
/// the storage systems, at least).
Expand Down Expand Up @@ -492,7 +493,7 @@ impl DataTable {
}

let Self {
table_id,
table_id: _,
row_id: _,
col_timelines,
entity_path: _,
Expand All @@ -509,8 +510,6 @@ impl DataTable {
columns.push(time_column);
}

schema.metadata = [(METADATA_TABLE_ID.into(), table_id.to_string())].into();

(schema, columns)
}

Expand Down

2 comments on commit 65a6962

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: 65a6962 Previous: 1713e60 Ratio
arrow2/size_bytes/primitive/rows=10000/instances=100/array 149237 ns/iter (± 799) 146739 ns/iter (± 561) 1.02
arrow2/size_bytes/primitive/rows=10000/instances=100/vec 3296 ns/iter (± 7) 3289 ns/iter (± 6) 1.00
arrow2/size_bytes/primitive/rows=10000/instances=100/vec/erased 17734 ns/iter (± 98) 17735 ns/iter (± 9) 1.00
arrow2/size_bytes/struct/rows=10000/instances=100/array 499399 ns/iter (± 3577) 485695 ns/iter (± 3487) 1.03
arrow2/size_bytes/struct/rows=10000/instances=100/vec 3296 ns/iter (± 9) 3291 ns/iter (± 8) 1.00
arrow2/size_bytes/struct/rows=10000/instances=100/vec/erased 17731 ns/iter (± 20) 17722 ns/iter (± 6) 1.00
arrow2/size_bytes/struct_large/rows=10000/instances=100/array 6607975 ns/iter (± 894690) 4325396 ns/iter (± 472983) 1.53
arrow2/size_bytes/struct_large/rows=10000/instances=100/vec 3996 ns/iter (± 9) 3986 ns/iter (± 14) 1.00
arrow2/size_bytes/struct_large/rows=10000/instances=100/vec/erased 17733 ns/iter (± 43) 17728 ns/iter (± 7) 1.00
arrow2/erased_clone/primitive/rows=10000/instances=100/cell/arc_erased 795466 ns/iter (± 2079) 799086 ns/iter (± 1985) 1.00
arrow2/erased_clone/primitive/rows=10000/instances=100/cell/wrapped_in_arc 192171 ns/iter (± 636) 195639 ns/iter (± 482) 0.98
arrow2/erased_clone/primitive/rows=10000/instances=100/array 745048 ns/iter (± 2399) 742243 ns/iter (± 2177) 1.00
arrow2/erased_clone/primitive/rows=10000/instances=100/array/downcast_first 353346 ns/iter (± 1163) 345258 ns/iter (± 1774) 1.02
arrow2/erased_clone/primitive/rows=10000/instances=100/vec/full_copy 1305094 ns/iter (± 201221) 1432802 ns/iter (± 147672) 0.91
arrow2/erased_clone/primitive/rows=10000/instances=100/vec/wrapped_in_arc 128484 ns/iter (± 168) 127135 ns/iter (± 230) 1.01
arrow2/erased_clone/struct/rows=10000/instances=100/cell/arc_erased 5127209 ns/iter (± 761422) 4674567 ns/iter (± 246438) 1.10
arrow2/erased_clone/struct/rows=10000/instances=100/cell/wrapped_in_arc 278715 ns/iter (± 1823) 278073 ns/iter (± 875) 1.00
arrow2/erased_clone/struct/rows=10000/instances=100/array 4372052 ns/iter (± 357263) 4698680 ns/iter (± 335213) 0.93
arrow2/erased_clone/struct/rows=10000/instances=100/array/downcast_first 3656108 ns/iter (± 257728) 4185773 ns/iter (± 169580) 0.87
arrow2/erased_clone/struct/rows=10000/instances=100/vec/full_copy 1354255 ns/iter (± 82370) 1404705 ns/iter (± 171255) 0.96
arrow2/erased_clone/struct/rows=10000/instances=100/vec/wrapped_in_arc 127006 ns/iter (± 163) 127829 ns/iter (± 130) 0.99
arrow2/erased_clone/struct_large/rows=10000/instances=100/cell/arc_erased 55425089 ns/iter (± 3663010) 49339245 ns/iter (± 291721) 1.12
arrow2/erased_clone/struct_large/rows=10000/instances=100/cell/wrapped_in_arc 167359 ns/iter (± 339) 173341 ns/iter (± 582) 0.97
arrow2/erased_clone/struct_large/rows=10000/instances=100/array 54255637 ns/iter (± 632399) 48133569 ns/iter (± 404751) 1.13
arrow2/erased_clone/struct_large/rows=10000/instances=100/array/downcast_first 51896964 ns/iter (± 1185335) 46491274 ns/iter (± 537484) 1.12
arrow2/erased_clone/struct_large/rows=10000/instances=100/vec/full_copy 5505491 ns/iter (± 184197) 5066246 ns/iter (± 85901) 1.09
arrow2/erased_clone/struct_large/rows=10000/instances=100/vec/wrapped_in_arc 127463 ns/iter (± 293) 126956 ns/iter (± 403) 1.00
arrow2_convert/serialize/primitive/instances=100000/arrow2_convert 413837 ns/iter (± 766) 415374 ns/iter (± 4568) 1.00
arrow2_convert/serialize/primitive/instances=100000/arrow2/from_values 19707 ns/iter (± 91) 19460 ns/iter (± 66) 1.01
arrow2_convert/serialize/primitive/instances=100000/arrow2/from_vec 19672 ns/iter (± 90) 19479 ns/iter (± 111) 1.01
arrow2_convert/deserialize/primitive/instances=100000/arrow2_convert 95941 ns/iter (± 266) 98494 ns/iter (± 1060) 0.97
arrow2_convert/deserialize/primitive/instances=100000/arrow2/validity_checks 162600 ns/iter (± 368) 161263 ns/iter (± 394) 1.01
arrow2_convert/deserialize/primitive/instances=100000/arrow2/validity_bypass 58446 ns/iter (± 262) 58607 ns/iter (± 168) 1.00
datastore/num_rows=1000/num_instances=1000/packed=false/insert/default 11924014 ns/iter (± 812896) 13351790 ns/iter (± 464566) 0.89
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=0 14230330 ns/iter (± 1195964) 15398070 ns/iter (± 756505) 0.92
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=2 13884047 ns/iter (± 1066100) 14207999 ns/iter (± 580479) 0.98
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=32 12296844 ns/iter (± 885274) 14757831 ns/iter (± 1261883) 0.83
datastore/num_rows=1000/num_instances=1000/packed=false/insert/bucketsz=2048 11591197 ns/iter (± 940840) 12792116 ns/iter (± 731378) 0.91
datastore/num_rows=1000/num_instances=1000/packed=true/insert/default 11785446 ns/iter (± 809465) 12484322 ns/iter (± 487203) 0.94
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=0 13587102 ns/iter (± 1151007) 14964285 ns/iter (± 670735) 0.91
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=2 14060540 ns/iter (± 1221033) 14910080 ns/iter (± 769303) 0.94
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=32 11987805 ns/iter (± 866765) 12373254 ns/iter (± 538765) 0.97
datastore/num_rows=1000/num_instances=1000/packed=true/insert/bucketsz=2048 12241858 ns/iter (± 1089947) 14589731 ns/iter (± 473161) 0.84
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/default 1830 ns/iter (± 20) 1831 ns/iter (± 26) 1.00
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=0 1856 ns/iter (± 8) 1818 ns/iter (± 4) 1.02
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=2 1864 ns/iter (± 17) 1813 ns/iter (± 1) 1.03
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=32 1824 ns/iter (± 15) 1823 ns/iter (± 4) 1.00
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at/bucketsz=2048 1828 ns/iter (± 16) 1800 ns/iter (± 1) 1.02
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/default 1836 ns/iter (± 25) 1836 ns/iter (± 18) 1
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=0 1821 ns/iter (± 1) 1852 ns/iter (± 1) 0.98
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=2 1830 ns/iter (± 5) 1838 ns/iter (± 3) 1.00
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=32 1850 ns/iter (± 20) 1826 ns/iter (± 1) 1.01
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at/bucketsz=2048 1804 ns/iter (± 5) 1815 ns/iter (± 3) 0.99
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/default 281 ns/iter (± 0) 279 ns/iter (± 0) 1.01
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/default 434 ns/iter (± 0) 435 ns/iter (± 0) 1.00
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=0 281 ns/iter (± 0) 279 ns/iter (± 0) 1.01
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=0 441 ns/iter (± 4) 443 ns/iter (± 0) 1.00
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=2 280 ns/iter (± 0) 279 ns/iter (± 0) 1.00
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=2 441 ns/iter (± 1) 444 ns/iter (± 0) 0.99
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=32 281 ns/iter (± 0) 279 ns/iter (± 0) 1.01
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=32 438 ns/iter (± 0) 440 ns/iter (± 0) 1.00
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/primary/bucketsz=2048 281 ns/iter (± 0) 279 ns/iter (± 0) 1.01
datastore/num_rows=1000/num_instances=1000/packed=false/latest_at_missing/secondaries/bucketsz=2048 434 ns/iter (± 1) 436 ns/iter (± 0) 1.00
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/default 281 ns/iter (± 1) 279 ns/iter (± 0) 1.01
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/default 437 ns/iter (± 1) 438 ns/iter (± 0) 1.00
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=0 280 ns/iter (± 0) 278 ns/iter (± 0) 1.01
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=0 442 ns/iter (± 2) 443 ns/iter (± 0) 1.00
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=2 281 ns/iter (± 0) 278 ns/iter (± 0) 1.01
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=2 442 ns/iter (± 0) 443 ns/iter (± 0) 1.00
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=32 281 ns/iter (± 1) 279 ns/iter (± 0) 1.01
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=32 438 ns/iter (± 0) 440 ns/iter (± 0) 1.00
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/primary/bucketsz=2048 281 ns/iter (± 0) 279 ns/iter (± 0) 1.01
datastore/num_rows=1000/num_instances=1000/packed=true/latest_at_missing/secondaries/bucketsz=2048 434 ns/iter (± 0) 437 ns/iter (± 5) 0.99
datastore/num_rows=1000/num_instances=1000/packed=false/range/default 13749722 ns/iter (± 1421091) 15045488 ns/iter (± 716728) 0.91
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=0 2158779 ns/iter (± 34994) 2185023 ns/iter (± 146517) 0.99
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=2 2229617 ns/iter (± 90918) 2237585 ns/iter (± 70869) 1.00
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=32 1896533 ns/iter (± 50363) 1930882 ns/iter (± 19864) 0.98
datastore/num_rows=1000/num_instances=1000/packed=false/range/bucketsz=2048 1905999 ns/iter (± 28789) 1860645 ns/iter (± 10489) 1.02
datastore/num_rows=1000/num_instances=1000/packed=true/range/default 12735554 ns/iter (± 1080826) 11723287 ns/iter (± 755827) 1.09
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=0 2125474 ns/iter (± 48394) 2130921 ns/iter (± 15375) 1.00
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=2 2181339 ns/iter (± 16438) 2183148 ns/iter (± 63610) 1.00
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=32 1841339 ns/iter (± 9165) 1845812 ns/iter (± 14449) 1.00
datastore/num_rows=1000/num_instances=1000/packed=true/range/bucketsz=2048 1796775 ns/iter (± 17063) 1802793 ns/iter (± 9603) 1.00
vector_ops/sort/instances=10000/smallvec/n=4 12491 ns/iter (± 32) 12494 ns/iter (± 18) 1.00
vector_ops/sort/instances=10000/tinyvec/n=4 9650 ns/iter (± 44) 9648 ns/iter (± 23) 1.00
vector_ops/sort/instances=10000/vec 9635 ns/iter (± 31) 9647 ns/iter (± 24) 1.00
vector_ops/split_off/instances=10000/smallvec/n=4/manual 5547 ns/iter (± 7) 5545 ns/iter (± 8) 1.00
vector_ops/split_off/instances=10000/tinyvec/n=4 2731 ns/iter (± 30) 2728 ns/iter (± 21) 1.00
vector_ops/split_off/instances=10000/tinyvec/n=4/manual 2745 ns/iter (± 20) 2737 ns/iter (± 20) 1.00
vector_ops/split_off/instances=10000/vec 2722 ns/iter (± 28) 2722 ns/iter (± 9) 1
vector_ops/split_off/instances=10000/vec/manual 2724 ns/iter (± 66) 2669 ns/iter (± 23) 1.02
vector_ops/swap/instances=10000/smallvec/n=4 32757 ns/iter (± 70) 32825 ns/iter (± 25) 1.00
vector_ops/swap/instances=10000/tinyvec/n=4 18282 ns/iter (± 74) 18267 ns/iter (± 39) 1.00
vector_ops/swap/instances=10000/vec 12314 ns/iter (± 70) 12305 ns/iter (± 11) 1.00
vector_ops/swap_opt/instances=10000/smallvec/n=4 42701 ns/iter (± 162) 42783 ns/iter (± 29) 1.00
vector_ops/swap_opt/instances=10000/tinyvec/n=4 28794 ns/iter (± 144) 28951 ns/iter (± 40) 0.99
vector_ops/swap_opt/instances=10000/vec 20426 ns/iter (± 82) 19877 ns/iter (± 24) 1.03
mono_points_arrow/generate_message_bundles 47304609 ns/iter (± 999191) 43786397 ns/iter (± 614340) 1.08
mono_points_arrow/generate_messages 153611241 ns/iter (± 1216198) 165142476 ns/iter (± 1100322) 0.93
mono_points_arrow/encode_log_msg 189357739 ns/iter (± 2944789) 208007785 ns/iter (± 1227384) 0.91
mono_points_arrow/encode_total 386611467 ns/iter (± 2924719) 416443519 ns/iter (± 4144644) 0.93
mono_points_arrow/decode_log_msg 225981680 ns/iter (± 1194130) 256243054 ns/iter (± 2010532) 0.88
mono_points_arrow/decode_message_bundles 82759949 ns/iter (± 1051151) 86437840 ns/iter (± 750776) 0.96
mono_points_arrow/decode_total 307144938 ns/iter (± 1695377) 340947320 ns/iter (± 2861077) 0.90
mono_points_arrow_batched/generate_message_bundles 42758340 ns/iter (± 2090511) 35865013 ns/iter (± 1159290) 1.19
mono_points_arrow_batched/generate_messages 8725584 ns/iter (± 1053961) 9807303 ns/iter (± 549899) 0.89
mono_points_arrow_batched/encode_log_msg 1547677 ns/iter (± 5639) 1797241 ns/iter (± 3250) 0.86
mono_points_arrow_batched/encode_total 49277479 ns/iter (± 3180142) 48475411 ns/iter (± 1364836) 1.02
mono_points_arrow_batched/decode_log_msg 861160 ns/iter (± 4115) 988663 ns/iter (± 8610) 0.87
mono_points_arrow_batched/decode_message_bundles 11514971 ns/iter (± 1029854) 19035605 ns/iter (± 949174) 0.60
mono_points_arrow_batched/decode_total 13280578 ns/iter (± 1539603) 21353719 ns/iter (± 834984) 0.62
batch_points_arrow/generate_message_bundles 297807 ns/iter (± 1278) 284873 ns/iter (± 757) 1.05
batch_points_arrow/generate_messages 6051 ns/iter (± 31) 7672 ns/iter (± 25) 0.79
batch_points_arrow/encode_log_msg 378573 ns/iter (± 2397) 389818 ns/iter (± 5572) 0.97
batch_points_arrow/encode_total 694261 ns/iter (± 6783) 693208 ns/iter (± 5658) 1.00
batch_points_arrow/decode_log_msg 356127 ns/iter (± 1514) 340579 ns/iter (± 2354) 1.05
batch_points_arrow/decode_message_bundles 2297 ns/iter (± 10) 2938 ns/iter (± 8) 0.78
batch_points_arrow/decode_total 364740 ns/iter (± 2243) 354156 ns/iter (± 3837) 1.03
arrow_mono_points/insert 6972011894 ns/iter (± 36398942) 6198787871 ns/iter (± 109272271) 1.12
arrow_mono_points/query 1830745 ns/iter (± 24499) 1872440 ns/iter (± 23630) 0.98
arrow_batch_points/insert 3019482 ns/iter (± 21099) 3026018 ns/iter (± 17782) 1.00
arrow_batch_points/query 16384 ns/iter (± 38) 16424 ns/iter (± 26) 1.00
arrow_batch_vecs/insert 43430 ns/iter (± 589) 43032 ns/iter (± 172) 1.01
arrow_batch_vecs/query 506202 ns/iter (± 1418) 505899 ns/iter (± 369) 1.00
tuid/Tuid::random 34 ns/iter (± 0) 34 ns/iter (± 0) 1

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.

Benchmark suite Current: 65a6962 Previous: 1713e60 Ratio
arrow2/size_bytes/struct_large/rows=10000/instances=100/array 6607975 ns/iter (± 894690) 4325396 ns/iter (± 472983) 1.53

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.