Skip to content

Commit

Permalink
Convert objectron proto.py back to using typing.List (#2559)
Browse files Browse the repository at this point in the history
### What

The change from List -> list was introduced as part of:
 - #2361
 
However it seems to break objectron on python3.8:
 - #2557

Reverting just this bit causes it to work for me, though I don't fully
understand the intention or ramifications.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested https://demo.rerun.io/pr/2559 (if applicable)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2559

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/4073c08/docs
Examples preview: https://rerun.io/preview/4073c08/examples
<!-- pr-link-docs:end -->
  • Loading branch information
jleibs authored and emilk committed Jun 29, 2023
1 parent 1d5df59 commit 89320db
Showing 1 changed file with 46 additions and 46 deletions.
92 changes: 46 additions & 46 deletions examples/python/objectron/proto/objectron/proto.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 89320db

Please sign in to comment.