Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix camera tracking delay/flicker (#2667)
Fixes #2201 * #2201 The issue is about the lines flickering in and out and the proposed solution was to not render the lines. But turns out the image itself was also flickering when I tested with structure_from_motion sample. Turned out we didn't accurately track the camera, doing so works perfectly fine and doesn't need special handling on the frustum lines. Fixes #2660 * #2660 I thought this was related (because I thought above would be about hiding lines), but now this is a regression fix that is just piggy backing here. PR description is about the thing that was actually broken in a release (but presumably worked before) Test it yourself: * got to https://demo.rerun.io/pr/2667 * click camera - observe the frustum lines are correct now * double click the camera to focus on it and play - no flickering should occur * try the same while the camera is already moving ### What ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2667) (if applicable) - [PR Build Summary](https://build.rerun.io/pr/2667) - [Docs preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-frustum-line-issues/docs) - [Examples preview](https://rerun.io/preview/pr%3Aandreas%2Ffix-frustum-line-issues/examples)
- Loading branch information
95e9756
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
1.25
.batch_points_arrow/encode_log_msg
89081
ns/iter (± 1648
)48670
ns/iter (± 91
)1.83
This comment was automatically generated by workflow using github-action-benchmark.