Skip to content

Commit

Permalink
Allow editing visual bounds from ui (#6492)
Browse files Browse the repository at this point in the history
### What

* Fixes #6237 

This also introduces the concept of multiline editors - didn't want to
split it out since then I'd be lacking a working example for it, but
commits are split along that falt line.
With introduction of multiline editors I refactored the view property ui
functionality such that parts will be more reusable in the future.



https://github.com/rerun-io/rerun/assets/1220815/a2584429-d560-49cb-9b0f-c766eb6a8104



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using examples from latest `main` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6492?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[rerun.io/viewer](https://rerun.io/viewer/pr/6492?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG
* [x] If applicable, add a new check to the [release
checklist](https://github.com/rerun-io/rerun/blob/main/tests/python/release_checklist)!

- [PR Build Summary](https://build.rerun.io/pr/6492)
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)

To run all checks from `main`, comment on the PR with `@rerun-bot
full-check`.
  • Loading branch information
Wumpf committed Jun 5, 2024
1 parent aaf9d5e commit 9aa6645
Show file tree
Hide file tree
Showing 27 changed files with 1,301 additions and 442 deletions.
1 change: 1 addition & 0 deletions Cargo.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5271,6 +5271,7 @@ dependencies = [
"anyhow",
"arboard",
"bit-vec",
"bitflags 2.5.0",
"bytemuck",
"egui",
"egui-wgpu",
Expand Down
2 changes: 1 addition & 1 deletion crates/re_data_ui/src/component_ui_registry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ pub fn create_component_ui_registry() -> ComponentUiRegistry {

/// Registers how to show a given component in the ui.
pub fn add_to_registry<C: EntityDataUi + re_types::Component>(registry: &mut ComponentUiRegistry) {
registry.add(
registry.add_display_ui(
C::name(),
Box::new(
|ctx, ui, ui_layout, query, db, entity_path, component, instance| {
Expand Down
Loading

0 comments on commit 9aa6645

Please sign in to comment.