Skip to content

Commit

Permalink
Fix log spam during data store tests (#3149)
Browse files Browse the repository at this point in the history
The default value of `indexed_bucket_num_rows` is 512, but in some tests
we set it to 0 or 1. That produces a lot of spurious warnings.

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/3149) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/3149)
- [Docs
preview](https://rerun.io/preview/11ba205b2c1cd8ba6d48b7512912f56490adf86c/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/11ba205b2c1cd8ba6d48b7512912f56490adf86c/examples)
<!--EXAMPLES-PREVIEW--><!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
  • Loading branch information
emilk committed Aug 30, 2023
1 parent 75cda47 commit ea543a1
Showing 1 changed file with 16 additions and 12 deletions.
28 changes: 16 additions & 12 deletions crates/re_arrow_store/src/store_write.rs
Original file line number Diff line number Diff line change
Expand Up @@ -380,20 +380,24 @@ impl IndexedTable {
}
}

let bucket_time_range = bucket.inner.read().time_range;
if 0 < config.indexed_bucket_num_rows {
let bucket_time_range = bucket.inner.read().time_range;

re_log::debug_once!(
"Failed to split bucket on timeline {}",
bucket.timeline.format_time_range(&bucket_time_range)
);

if bucket_time_range.min == bucket_time_range.max {
re_log::warn_once!(
"Found over {} rows with the same timepoint {:?}={} - perhaps you forgot to update or remove the timeline?",
config.indexed_bucket_num_rows,
bucket.timeline.name(),
bucket.timeline.typ().format(bucket_time_range.min)
re_log::debug_once!(
"Failed to split bucket on timeline {}",
bucket.timeline.format_time_range(&bucket_time_range)
);

if 1 < config.indexed_bucket_num_rows
&& bucket_time_range.min == bucket_time_range.max
{
re_log::warn_once!(
"Found over {} rows with the same timepoint {:?}={} - perhaps you forgot to update or remove the timeline?",
config.indexed_bucket_num_rows,
bucket.timeline.name(),
bucket.timeline.typ().format(bucket_time_range.min)
);
}
}
}

Expand Down

0 comments on commit ea543a1

Please sign in to comment.