Skip to content

Commit

Permalink
Add banner about mobile browsers being unsupported (#1674)
Browse files Browse the repository at this point in the history
* Add banner about missing support on mobile browsers

* Clarify mobile isn't supported in general (not just limited to web)
  • Loading branch information
jleibs committed Mar 22, 2023
1 parent 5e660cf commit f20c7ca
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions crates/re_viewer/src/app.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1012,10 +1012,12 @@ impl AppState {
}
}

fn warning_panel(re_ui: &re_ui::ReUi, ui: &mut egui::Ui, frame: &mut eframe::Frame) {
// We have some bugs when running the web viewer on Windows.
// See https://github.com/rerun-io/rerun/issues/1206
if frame.is_web() && ui.ctx().os() == egui::os::OperatingSystem::Windows {
fn warning_panel(re_ui: &re_ui::ReUi, ui: &mut egui::Ui, _frame: &mut eframe::Frame) {
// We have not yet optimized the UI experience for mobile. Show a warning banner
// with a link to the tracking issue.
if ui.ctx().os() == egui::os::OperatingSystem::IOS
|| ui.ctx().os() == egui::os::OperatingSystem::Android
{
let frame = egui::Frame {
fill: ui.visuals().panel_fill,
..re_ui.bottom_panel_frame()
Expand All @@ -1026,10 +1028,9 @@ fn warning_panel(re_ui: &re_ui::ReUi, ui: &mut egui::Ui, frame: &mut eframe::Fra
.frame(frame)
.show_inside(ui, |ui| {
ui.centered_and_justified(|ui| {
let text = re_ui.warning_text(
"The web viewer has some known issues on Windows. Click for details.",
);
ui.hyperlink_to(text, "https://github.com/rerun-io/rerun/issues/1206");
let text =
re_ui.warning_text("Mobile OSes are not yet supported. Click for details.");
ui.hyperlink_to(text, "https://github.com/rerun-io/rerun/issues/1672");
});
});
}
Expand Down

1 comment on commit f20c7ca

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rust Benchmark

Benchmark suite Current: f20c7ca Previous: 2e64016 Ratio
datastore/insert/batch/rects/insert 556238 ns/iter (± 4287) 569900 ns/iter (± 2358) 0.98
datastore/latest_at/batch/rects/query 1828 ns/iter (± 15) 1867 ns/iter (± 7) 0.98
datastore/latest_at/missing_components/primary 283 ns/iter (± 3) 289 ns/iter (± 0) 0.98
datastore/latest_at/missing_components/secondaries 434 ns/iter (± 4) 448 ns/iter (± 1) 0.97
datastore/range/batch/rects/query 149670 ns/iter (± 1351) 154597 ns/iter (± 753) 0.97
mono_points_arrow/generate_message_bundles 47919544 ns/iter (± 1524961) 49779355 ns/iter (± 1351686) 0.96
mono_points_arrow/generate_messages 137200269 ns/iter (± 1504923) 136042834 ns/iter (± 1401120) 1.01
mono_points_arrow/encode_log_msg 165278926 ns/iter (± 1280798) 164969686 ns/iter (± 702847) 1.00
mono_points_arrow/encode_total 354610501 ns/iter (± 2089142) 355563422 ns/iter (± 1987416) 1.00
mono_points_arrow/decode_log_msg 186698663 ns/iter (± 1448389) 189280399 ns/iter (± 1120549) 0.99
mono_points_arrow/decode_message_bundles 72467321 ns/iter (± 1197827) 72421268 ns/iter (± 1577651) 1.00
mono_points_arrow/decode_total 256947510 ns/iter (± 2259729) 259023617 ns/iter (± 2219112) 0.99
batch_points_arrow/generate_message_bundles 332570 ns/iter (± 3568) 337325 ns/iter (± 653) 0.99
batch_points_arrow/generate_messages 6244 ns/iter (± 96) 6319 ns/iter (± 16) 0.99
batch_points_arrow/encode_log_msg 365513 ns/iter (± 2480) 457993 ns/iter (± 2748) 0.80
batch_points_arrow/encode_total 737680 ns/iter (± 7372) 727078 ns/iter (± 2313) 1.01
batch_points_arrow/decode_log_msg 346337 ns/iter (± 2720) 346901 ns/iter (± 638) 1.00
batch_points_arrow/decode_message_bundles 2025 ns/iter (± 28) 2051 ns/iter (± 2) 0.99
batch_points_arrow/decode_total 354330 ns/iter (± 2482) 349640 ns/iter (± 466) 1.01
arrow_mono_points/insert 7021385217 ns/iter (± 10871066) 6859372698 ns/iter (± 24351271) 1.02
arrow_mono_points/query 1763061 ns/iter (± 18951) 1765899 ns/iter (± 13401) 1.00
arrow_batch_points/insert 2625708 ns/iter (± 24320) 2600994 ns/iter (± 36458) 1.01
arrow_batch_points/query 15940 ns/iter (± 181) 16199 ns/iter (± 73) 0.98
arrow_batch_vecs/insert 42675 ns/iter (± 196) 41724 ns/iter (± 71) 1.02
arrow_batch_vecs/query 388988 ns/iter (± 2511) 388657 ns/iter (± 290) 1.00
tuid/Tuid::random 34 ns/iter (± 0) 34 ns/iter (± 0) 1

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.