Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banner about mobile browsers being unsupported #1674

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Mar 22, 2023

If a user decides to click through, make sure we still show a notification about the fact that mobile is not yet actually supported with a link to the tracking issue.

Also remove the windows banner since windows now generally works.

Tracking issue:

image

Checklist

@jleibs jleibs added the ui concerns graphical user interface label Mar 22, 2023
@jleibs jleibs marked this pull request as ready for review March 22, 2023 18:42
@jleibs jleibs changed the title Add banner about missing support on mobile browsers Add banner about mobile browsers being unsupported Mar 22, 2023
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!!

@Wumpf Wumpf merged commit f20c7ca into main Mar 22, 2023
@Wumpf Wumpf deleted the jleibs/mobile_banner branch March 22, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui concerns graphical user interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants