Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak outlines: small objects and color #1614

Closed
nikolausWest opened this issue Mar 20, 2023 · 0 comments · Fixed by #1667
Closed

Tweak outlines: small objects and color #1614

nikolausWest opened this issue Mar 20, 2023 · 0 comments · Fixed by #1667
Assignees
@Wumpf
Labels
🔺 re_renderer affects re_renderer itself

Comments

@nikolausWest
Copy link
Member

Outlines currently often look to bright (almost neon) in a way that makes it hard to see the data. For batches of smaller objects, like points and lines, the outlines also end up around each point, negating the value of using outlines vs just setting a selection color.

Image
@nikolausWest nikolausWest added the 🔺 re_renderer affects re_renderer itself label Mar 20, 2023
@Wumpf Wumpf self-assigned this Mar 20, 2023
This was referenced Mar 20, 2023
Merged
Merged
Wumpf added a commit that referenced this issue Mar 22, 2023
@Wumpf
Fix outlines being offset diagonally by about half a pixel
b8db2b3 
Fixes very subtle bug that caused outlines to be offset. With the gaps introduced in #1614 this became more quite apparent in some situations (at least if you're glued with your nose to the screen like myself ;))
@Wumpf Wumpf mentioned this issue Mar 22, 2023
Merged
2 tasks
Wumpf added a commit that referenced this issue Mar 22, 2023
@Wumpf
Fix outlines being offset diagonally by about half a pixel (#1668)
5e660cf 
Fixes very subtle bug that caused outlines to be offset. With the gaps introduced in #1614 this became more quite apparent in some situations (at least if you're glued with your nose to the screen like myself ;))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🔺 re_renderer affects re_renderer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Size boosted outlines for points & lines, color & size tweaking rerun-io/rerun
2 participants
@Wumpf @nikolausWest