Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Size boosted outlines for points & lines, color & size tweaking #1667

Merged
merged 10 commits into from Mar 23, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 22, 2023

Screen.Recording.2023-03-22.at.11.14.00.mov

Fixes #1614

Checklist

@Wumpf Wumpf added 🔺 re_renderer affects re_renderer itself 📺 re_viewer affects re_viewer itself labels Mar 22, 2023
@Wumpf Wumpf marked this pull request as draft March 22, 2023 10:20
@Wumpf Wumpf marked this pull request as ready for review March 22, 2023 10:24
@Wumpf
Copy link
Member Author

Wumpf commented Mar 22, 2023

Latest commit for outline gap fixing:
Before:
image

After:
image

@emilk
Copy link
Member

emilk commented Mar 22, 2023

I find the outline way too weak - it is very hard to tell whether or not I'm hovering something on a bad display

outline-weak

@Wumpf
Copy link
Member Author

Wumpf commented Mar 22, 2023

I find the outline way too weak - it is very hard to tell whether or not I'm hovering something on a bad display

Fairly controversial. We discussed this in the office together with @nikolausWest and didn't come to a strong conclusion. But the leaning seems to be to leave it as is for the moment.

@nikolausWest
Copy link
Member

I find the outline way too weak - it is very hard to tell whether or not I'm hovering something on a bad display

Fairly controversial. We discussed this in the office together with @nikolausWest and didn't come to a strong conclusion. But the leaning seems to be to leave it as is for the moment.

I'm definitely open to making it more pronounced but i do like it when it doesn't take over to much. I also like the consistency of having the colors at least be similar to select and hover in other parts of the UI

crates/re_renderer/shader/lines.wgsl Outdated Show resolved Hide resolved
crates/re_renderer/shader/utils/size.wgsl Outdated Show resolved Hide resolved
@Wumpf Wumpf merged commit 0dc563e into main Mar 23, 2023
17 checks passed
@Wumpf Wumpf deleted the andreas/outlines-tweaks branch March 23, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔺 re_renderer affects re_renderer itself 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweak outlines: small objects and color
3 participants