Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RGB frame / gizmo associated with rigid transform is not configurable #2269

Closed
roym899 opened this issue May 30, 2023 · 0 comments · Fixed by #2577
Closed

RGB frame / gizmo associated with rigid transform is not configurable #2269

roym899 opened this issue May 30, 2023 · 0 comments · Fixed by #2577
Labels
😤 annoying Something in the UI / SDK is annoying to use enhancement New feature or request 📺 re_viewer affects re_viewer itself

Comments

@roym899
Copy link
Collaborator

roym899 commented May 30, 2023

Describe the annoyance
The size of the RGB frame / gizmo associated with rigid transforms is not configurable right now. Its size is currently independent of the zoom which can be an issue if many such transforms are logged.

Expected behavior
It would be nice to make the frame size configurable. Both size and whether it should be affected by zoom or not.

Desktop (please complete the following information):

  • OS: Ubuntu 20.04

Additional context

rerun_py 0.7.0-alpha.0+ [rustc 1.69.0 (84c898d65 2023-04-16), LLVM 15.0.7] x86_64-unknown-linux-gnu main b263b9f, built 2023-05-29T18:38:22Z
@roym899 roym899 added 👀 needs triage This issue needs to be triaged by the Rerun team 😤 annoying Something in the UI / SDK is annoying to use labels May 30, 2023
@nikolausWest nikolausWest added the 📺 re_viewer affects re_viewer itself label Jun 21, 2023
@emilk emilk mentioned this issue Jul 4, 2023
Merged
3 tasks
@emilk emilk added enhancement New feature or request and removed 👀 needs triage This issue needs to be triaged by the Rerun team labels Jul 4, 2023
Wumpf added a commit that referenced this issue Jul 17, 2023
@Wumpf
Consistent transform visualization for all entities with transforms (#…
227b49c 
…2577)

### What

Fixes #753. Fixes #2503. Fixes #2269
* #753 
* #2503
* #2269

Adds a new scene part to visualize all transform arrows - decided to
avoid the term "gizmo" since gizmos as they are used for manipulating an
object (e.g. Blender, Unity3D, Unreal etc.) do have quite different
properties in what they need to show and are typically *not* used to
visualize the actual transform.

Introduces two new properties that (like all other object properties)
will need to be componetized and be part of the blueprint apis:
* transform visibility: On by default iff the entity or any of its
children has a pinhole transform or if the entity doesn't have any other
components than `Transform3D`
* transform arrow length: By default a heuristic world bounding box
based scale, can be chosen freely per object.

Polished the api_demo#transform_test a little bit to be able to use it
as a test case for this:

![image](https://github.com/rerun-io/rerun/assets/1220815/538a8cee-36f9-4af0-a5a6-51723f6e925f)

Note in particular that skew & scale works as expected:

![image](https://github.com/rerun-io/rerun/assets/1220815/4482d9b8-6e12-405a-9431-bf18ac7d413f)

(this shows two transforms on the same spot, one rotated along x, one
scaled along x)

![image](https://github.com/rerun-io/rerun/assets/1220815/b18d18c0-4ba6-4e84-a1e0-f125320655e8)


Pinhole cameras no longer are hacked to have their private gizmo -
clicking it clicks the entity with the transform now, now the pinhole
camera (this _may_ be the same, see #2568):

![image](https://github.com/rerun-io/rerun/assets/1220815/ce04c4a4-0d77-4a91-abbc-1331b3b5f36e)



### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2577) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2577)
- [Docs
preview](https://rerun.io/preview/pr%3Aandreas%2Ftransform-gizmos/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Aandreas%2Ftransform-gizmos/examples)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
😤 annoying Something in the UI / SDK is annoying to use enhancement New feature or request 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consistent transform visualization for all entities with transforms rerun-io/rerun
3 participants
@emilk @nikolausWest @roym899