Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transforms are not applied to connection between keypoints #2402

Closed
abey79 opened this issue Jun 13, 2023 · 1 comment · Fixed by #2407
Closed

Transforms are not applied to connection between keypoints #2402

abey79 opened this issue Jun 13, 2023 · 1 comment · Fixed by #2407
Assignees
@Wumpf
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself

Comments

@abey79
Copy link
Contributor

abey79 commented Jun 13, 2023

Describe the bug

Symptom:

image

As per Slack discussion:

image
@abey79 abey79 added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself labels Jun 13, 2023
@abey79 abey79 mentioned this issue Jun 13, 2023
Merged
2 tasks
@abey79
Copy link
Contributor Author

abey79 commented Jun 13, 2023

Possibly related to #2359

@abey79 abey79 mentioned this issue Jun 13, 2023
Open
@Wumpf Wumpf self-assigned this Jun 13, 2023
@Wumpf Wumpf mentioned this issue Jun 13, 2023
Merged
2 tasks
emilk pushed a commit that referenced this issue Jun 13, 2023
@Wumpf
Fix transforms not applied to connections from transform context (#2407)
76e7c9d 
<!--
Open the PR up as a draft until you feel it is ready for a proper
review.

Do not make PR:s from your own `main` branch, as that makes it difficult
for reviewers to add their own fixes.

Add any improvements to the branch as new commits to make it easier for
reviewers to follow the progress. All commits will be squashed to a
single commit once the PR is merged into `main`.

Make sure you mention any issues that this PR closes in the description,
as well as any other related issues.

To get an auto-generated PR description you can put "copilot:summary" or
"copilot:walkthrough" anywhere.
-->

### What

Applies to 2D & 3D connections between points.

Before:
<img width="488" alt="Screenshot 2023-06-13 at 10 47 08"
src="https://github.com/rerun-io/rerun/assets/1220815/a78a96b0-7169-43c3-8bd9-a46512bb583a">

After:
<img width="395" alt="Screenshot 2023-06-13 at 10 46 11"
src="https://github.com/rerun-io/rerun/assets/1220815/caf84de6-56ff-46e1-96c2-bf8e91ff3630">

Also briefly checkd that the other example with keypoints, mp_pose, also
still works

Fixes #2402
* #2402

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)

<!-- This line will get updated when the PR build summary job finishes.
-->
PR Build Summary: https://build.rerun.io/pr/2407

<!-- pr-link-docs:start -->
Docs preview: https://rerun.io/preview/fe899e0/docs
Examples preview: https://rerun.io/preview/fe899e0/examples
<!-- pr-link-docs:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix transforms not applied to connections from transform context rerun-io/rerun
2 participants
@Wumpf @abey79