Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always automatically derive Debug & Clone for Rust codegen backend #2521

Closed
teh-cmc opened this issue Jun 26, 2023 · 0 comments · Fixed by #2613
Closed

Always automatically derive Debug & Clone for Rust codegen backend #2521

teh-cmc opened this issue Jun 26, 2023 · 0 comments · Fixed by #2613
Labels
codegen/idl 🦀 Rust API Rust logging API 🕸️ web regarding running the viewer in a browser

Comments

@teh-cmc
Copy link
Member

teh-cmc commented Jun 26, 2023

Every single component/datatype definitions that we have specifies the following:

"attr.rust.derive": "Debug, Clone, ...",

We might as well just make Debug & Clone automatically implemented, always.

While we're at it, it might be wise to flag Debug behind a #[cfg(arch)], so that it doesn't pollute the wasm artifact?
@teh-cmc teh-cmc added 🕸️ web regarding running the viewer in a browser 🦀 Rust API Rust logging API codegen/idl labels Jun 26, 2023
teh-cmc added a commit that referenced this issue Jun 26, 2023
@teh-cmc
mention #2521
58e5f9d
teh-cmc added a commit that referenced this issue Jun 27, 2023
@teh-cmc
mention #2521
ceecd4c
teh-cmc added a commit that referenced this issue Jun 28, 2023
@teh-cmc
mention #2521
9dafbcc
teh-cmc added a commit that referenced this issue Jun 30, 2023
@teh-cmc
mention #2521
1a8edf8
@teh-cmc teh-cmc mentioned this issue Jul 5, 2023
Merged
3 tasks
teh-cmc added a commit that referenced this issue Jul 6, 2023
@teh-cmc
Automatically derive Debug and Clone in Rust backend (#2613)
e76ebd9 
Fixes #2521 

---

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/2613) (if
applicable)

- [PR Build Summary](https://build.rerun.io/pr/2613)
- [Docs
preview](https://rerun.io/preview/pr%3Acmc%2Fauto_derive_debug_clone/docs)
- [Examples
preview](https://rerun.io/preview/pr%3Acmc%2Fauto_derive_debug_clone/examples)
@teh-cmc teh-cmc mentioned this issue Sep 22, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
codegen/idl 🦀 Rust API Rust logging API 🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Automatically derive Debug and Clone in Rust backend rerun-io/rerun
1 participant
@teh-cmc