Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opening link on webviewer opens in the same tab #4105

Closed
Wumpf opened this issue Oct 31, 2023 · 2 comments · Fixed by #4582
Closed

Opening link on webviewer opens in the same tab #4105

Wumpf opened this issue Oct 31, 2023 · 2 comments · Fixed by #4582
Assignees
@emilk
Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser

Comments

@Wumpf
Copy link
Member

Wumpf commented Oct 31, 2023

pretty annoying to have the webapp be gone just because I clicked a documentation link with left mouse button instead of middle
@Wumpf Wumpf added 🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser 😤 annoying Something in the UI / SDK is annoying to use labels Oct 31, 2023
@emilk
Copy link
Member

emilk commented Dec 19, 2023

I assume you suggest all links should always open in a new tab?

@emilk emilk self-assigned this Dec 19, 2023
@emilk emilk mentioned this issue Dec 19, 2023
Merged
4 tasks
@Wumpf
Copy link
Member Author

Wumpf commented Dec 19, 2023

I figure that's what past-me meant, yep

emilk added a commit that referenced this issue Dec 19, 2023
@emilk
Open all links in a new tab (#4582)
6342c60 
### What
* Closes #4105

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested the web demo (if applicable):
* Using newly built examples:
[app.rerun.io](https://app.rerun.io/pr/4582/index.html)
* Using examples from latest `main` build:
[app.rerun.io](https://app.rerun.io/pr/4582/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json)
* Using full set of examples from `nightly` build:
[app.rerun.io](https://app.rerun.io/pr/4582/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4582)
- [Docs
preview](https://rerun.io/preview/e750f29d2359e8522dccba97274e6a9de47a3828/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/e750f29d2359e8522dccba97274e6a9de47a3828/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://build.rerun.io/graphs/crates.html)
- [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emilk emilk

Labels
😤 annoying Something in the UI / SDK is annoying to use 🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Open all links in a new tab rerun-io/rerun
2 participants
@emilk @Wumpf