Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve rerun_cpp readme.md and add it to the rerun_cpp_sdk.zip file #4117

Closed
Wumpf opened this issue Nov 1, 2023 · 0 comments · Fixed by #4126
Closed

Improve rerun_cpp readme.md and add it to the rerun_cpp_sdk.zip file #4117

Wumpf opened this issue Nov 1, 2023 · 0 comments · Fixed by #4126
Assignees
@Wumpf
Labels
🌊 C++ API C or C++ logging API 📖 documentation Improvements or additions to documentation

Comments

@Wumpf
Copy link
Member

Wumpf commented Nov 1, 2023

Also, we should make rerun_cpp/CMakeLists.txt as easy as possible: Go through it, document it better and move the ExternalProject arrow settings into a separate file
@Wumpf Wumpf added 📖 documentation Improvements or additions to documentation 🌊 C++ API C or C++ logging API labels Nov 1, 2023
@Wumpf Wumpf self-assigned this Nov 2, 2023
@Wumpf Wumpf mentioned this issue Nov 2, 2023
Merged
4 tasks
Wumpf added a commit that referenced this issue Nov 3, 2023
@Wumpf
Improve rerun_cpp readme & CMakeLists.txt (#4126)
c62c6a3 
### What

* Fixes #4117
* overhauled Readme.md for rerun_cpp
* everything except is now part of rerun_cpp zip bundle
* made rerun_cpp CMakeLists.txt smaller by splitting out the from-source
rerun_c and the from-source arrow builds out
* rerun_c is now built as a built action, meaning it's part of the
buildgraph of whatever generator you use - e.g. Ninja will build it now
in parallel to your C files 🥳

### Checklist
* [x] I have read and agree to [Contributor
Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and
the [Code of
Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md)
* [x] I've included a screenshot or gif (if applicable)
* [x] I have tested [demo.rerun.io](https://demo.rerun.io/pr/4126) (if
applicable)
* [x] The PR title and labels are set such as to maximize their
usefulness for the next release's CHANGELOG

- [PR Build Summary](https://build.rerun.io/pr/4126)
- [Docs
preview](https://rerun.io/preview/1f68439ed4731c219b116fd41e15638015b9d68b/docs)
<!--DOCS-PREVIEW-->
- [Examples
preview](https://rerun.io/preview/1f68439ed4731c219b116fd41e15638015b9d68b/examples)
<!--EXAMPLES-PREVIEW-->
- [Recent benchmark results](https://ref.rerun.io/dev/bench/)
- [Wasm size tracking](https://ref.rerun.io/dev/sizes/)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Wumpf Wumpf

Labels
🌊 C++ API C or C++ logging API 📖 documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve rerun_cpp readme & CMakeLists.txt rerun-io/rerun
1 participant
@Wumpf