UI for overriding SeriesStyle in TimeSeriesViews #4817
Assignees
Labels
Milestone
Comments
nikolausWest
added
enhancement
Merged
4 tasks
jleibs
added a commit
that referenced
this issue
Jan 29, 2024
…or overriding components (#4914) ### What - Part of #4817 This tackles the problem of allowing SeriesStyle components to be overridden by building out a significant chunk of a general component override framework. The new UI is limited to TimeSeriesScalar view at the moment because it still requires special Visualizer-side handling of the component data. ### High level idea When selecting an entity within a space-view, we now have the ability to override any component that is both queried by the visualizer, and for which we have a registered component-editor. This override value is initialized based on looking for, in order: - The current value of the component for the entity - A value provided by the Visualizer (useful for things like matching the current auto-color) - A default value provided by a function registered along with the editor. ### Notable changes: - Adds a new mechanism to the Component UI Registry that allows us to register editors and default-value providers for any component. - Adds a mechanism to all visualizers to find out the full set of components they query. - During the `update_overrides` process, we now checks the appropriate location in the blueprint override tree and insert the path to any overridden components into the DataResult. - In the TimeSeriesSpaceView we now respect any overrides that come from the DataResult. - Introduce a new Override Components UI in the seleciton panel, which allows us to add an override using a default-provided, or visualizer-provided initial value. - Once the override has been added, the override UI dispatches to the registered editor for each overridden component. ### Screenshot  ### Checklist * [x] I have read and agree to [Contributor Guide](https://github.com/rerun-io/rerun/blob/main/CONTRIBUTING.md) and the [Code of Conduct](https://github.com/rerun-io/rerun/blob/main/CODE_OF_CONDUCT.md) * [x] I've included a screenshot or gif (if applicable) * [x] I have tested the web demo (if applicable): * Using newly built examples: [app.rerun.io](https://app.rerun.io/pr/4914/index.html) * Using examples from latest `main` build: [app.rerun.io](https://app.rerun.io/pr/4914/index.html?manifest_url=https://app.rerun.io/version/main/examples_manifest.json) * Using full set of examples from `nightly` build: [app.rerun.io](https://app.rerun.io/pr/4914/index.html?manifest_url=https://app.rerun.io/version/nightly/examples_manifest.json) * [x] The PR title and labels are set such as to maximize their usefulness for the next release's CHANGELOG - [PR Build Summary](https://build.rerun.io/pr/4914) - [Docs preview](https://rerun.io/preview/e5f379759f9e985910550ab0258abdec4d4ca1a1/docs) <!--DOCS-PREVIEW--> - [Examples preview](https://rerun.io/preview/e5f379759f9e985910550ab0258abdec4d4ca1a1/examples) <!--EXAMPLES-PREVIEW--> - [Recent benchmark results](https://build.rerun.io/graphs/crates.html) - [Wasm size tracking](https://build.rerun.io/graphs/sizes.html)
|
We ended up doing it the other way round. We have now a universal mechanism for overriding components, but we still have to add more components to style a series. But the ui is basically in place! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Build out selection view UI to be able to override any options (components) in the
SeriesStylefor entities selected in a TimeSeriesViewThe text was updated successfully, but these errors were encountered: