Preview component data #1034
Merged
Preview component data #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also removes the |
jleibs
approved these changes
Feb 1, 2023
| } else { | ||
| ui.label(format!("{num_instances} values")); | ||
| // TODO(andreas): There should be a button leaving to a full view. | ||
| // Or once we figure out how to do full views of this just show everything in a scroll area |
There was a problem hiding this comment.
I can't wait for the scroll area.
emilk
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1024
Instead of showing that there are n values and not saying anything...
... we now show the first few and point out that there are more
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)