Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataUI impls for rect/linestrip2d/linestrip3d/vec2d/vec3d #1038

Merged
merged 5 commits into from
Feb 2, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Feb 1, 2023

partial fix for #1036 (the underlying problem is still around)

image

image

image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

jleibs
jleibs previously requested changes Feb 1, 2023
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but needs a fix on Rect2D:YXHW

crates/re_log_types/src/component_types/vec.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/data_ui/data.rs Outdated Show resolved Hide resolved
crates/re_log_types/src/component_types/vec.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/data_ui/data.rs Outdated Show resolved Hide resolved
@Wumpf Wumpf dismissed jleibs’s stale review February 2, 2023 10:12

resolved issue

@Wumpf Wumpf merged commit a59846a into main Feb 2, 2023
@Wumpf Wumpf deleted the andreas/more-dataui-impls branch February 2, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants