Generate an RRD file during the build which we inject into the wheel #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
force-pushed
the
jleibs/rerun_demo_rrd
branch
2 times, most recently
from
bdff221
to
1540ba0
Compare
jondo2010
reviewed
Feb 6, 2023
Comment on lines
+60
to
+86
| - name: Cache APT Packages | ||
| #uses: awalsh128/cache-apt-pkgs-action@v1.2.2 | ||
| #TODO(john) merge upstream | ||
| uses: rerun-io/cache-apt-pkgs-action@59534850182063abf1b2c11bb3686722a12a8397 | ||
| with: | ||
| packages: libgtk-3-dev libxcb-render0-dev libxcb-shape0-dev libxcb-xfixes0-dev libspeechd-dev libxkbcommon-dev libssl-dev libfontconfig1-dev libatk-bridge2.0 libfreetype6-dev libglib2.0-dev | ||
| version: 1.0 | ||
| execute_install_scripts: true | ||
|
|
||
| - name: Set up cargo cache | ||
| uses: Swatinem/rust-cache@v2 | ||
| with: | ||
| env-vars: CARGO CC CFLAGS CXX CMAKE RUST CACHE_KEY | ||
| # See: https://github.com/rerun-io/rerun/pull/497 | ||
| save-if: ${{ github.event_name == 'push'}} | ||
|
|
||
| - name: Setup python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: ${{ env.PYTHON_VERSION }} | ||
| architecture: x64 | ||
| cache: "pip" | ||
| cache-dependency-path: "rerun_py/requirements-build.txt" | ||
|
|
||
| - name: Build and install rerun | ||
| run: | | ||
| pip install rerun_py/ |
There was a problem hiding this comment.
I would swap this with a download of the previously-built wheel to avoid re-installing and re-building everything.
There was a problem hiding this comment.
There's a chicken-and-egg problem here -- there is't a previously built wheel. The wheels need to be built after this because we want to be able to use this artifact to inject into the wheel.
https://github.com/rerun-io/rerun/actions/runs/4088811222
There was a problem hiding this comment.
Don't need this yet, but an improvement (reduction in duplicate CI effort) will be to reduce the "generate .rrd" to entirely Rust so we can cut all the Python out of this job.
jleibs
force-pushed
the
jleibs/rerun_demo_rrd
branch
from
cab4cfc
to
441e1b5
Compare
jondo2010
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of: #1085 which will need to be landed first
We want it to be easy to spawn a rerun instance with some rich data with no other dependency on checking out the examples repo, etc.
The rrd file is a reasonable and portable mechanism of packing this data. Given that RRD files change over time, we don't want to check it into the repo, but instead generate it and inject it into the package at build time.
This PR also adds a new package
rerun_demo, similar to the rerun/main.py which instead spawns the viewer with the path to the rrd file.After pip installing the rerun package you can run the demo with:
As long as the package was built with the injected rrd file it will spawn the viewer. Otherwise you'll get an error
Checklist
CHANGELOG.md(if this is a big enough change to warrant it)