Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some links #1314

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Fix some links #1314

merged 3 commits into from
Feb 15, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 15, 2023

Also write "GitHub" instead of "Github" everywhere.

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@emilk emilk added the 📖 documentation Improvements or additions to documentation label Feb 15, 2023
@emilk
Copy link
Member Author

emilk commented Feb 15, 2023

I'm doing the same over at rerun-docs too


exclude_dirs = {"env", "venv", "target", "target_ra", "target_wasm"}

exclude_paths = {
"./CONTRIBUTING.md",
"./CODE_STYLE.md",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would CONTRIBUTING.md be spared tho?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CODE_STYLE mentions how NOT to write TODO, and so it triggers those lints

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooo it's an exclude, I see

@emilk
Copy link
Member Author

emilk commented Feb 15, 2023

Please double-check this, because I'm really tired

@emilk
Copy link
Member Author

emilk commented Feb 15, 2023

Sibling PR: rerun-io/rerun-docs#42

@emilk emilk merged commit 12f75ba into main Feb 15, 2023
@emilk emilk deleted the emilk/cleanup-links branch February 15, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants