Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signal handler on *nix with troubleshooting and stacktrace #1340

Merged
merged 3 commits into from Feb 17, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Feb 17, 2023

Previously a SIGSEGV would just terminate the application,printing segmentation fault and nothing else (on my Mac).

With this PR, you will now get

Rerun caught a signal: SIGSEGV
Troubleshooting Rerun: https://www.rerun.io/docs/getting-started/troubleshooting

followed by a stacktrace.

Tested on:

  • Mac
  • Linux

Test it like so:
image

Checklist

  • I have read and agree to Contributor Guide and the Code of Conduct
  • I've included a screenshot or gif (if applicable)
  • I've added a line to CHANGELOG.md (if this is a big enough change to warrant it)

@emilk emilk changed the title Emilk/signal handler Add signal handler on *nix with troubleshooting and stacktrace Feb 17, 2023
@emilk emilk added 📖 documentation Improvements or additions to documentation 📺 re_viewer affects re_viewer itself 💣 crash crash, deadlock/freeze, do-no-start labels Feb 17, 2023
Copy link
Member

@teh-cmc teh-cmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on Linux (well, except for stack overflows but I don't think it's worth chasing that considering the insanity it leads to...).

@emilk
Copy link
Member Author

emilk commented Feb 17, 2023

yeah, agree on the stack overflow.

https://github.com/EmbarkStudios/crash-handling is perhaps something worth investigating at some point, but it is quite a complicated beast.

@emilk emilk merged commit 3e4c194 into main Feb 17, 2023
@emilk emilk deleted the emilk/signal-handler branch February 17, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💣 crash crash, deadlock/freeze, do-no-start 📖 documentation Improvements or additions to documentation 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants