Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert view_tensor to use the new native Tensors #1439

Merged
merged 2 commits into from
Feb 28, 2023
Merged

Convert view_tensor to use the new native Tensors #1439

merged 2 commits into from
Feb 28, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Feb 28, 2023 •
edited
Loading

Converting to ClassicTensor was incurring an unnecessary copy.

image

Resolves: #1434

Checklist

@jleibs jleibs added the 📉 performance Optimization, memory use, etc label Feb 28, 2023
@jleibs jleibs marked this pull request as ready for review February 28, 2023 15:21
@emilk emilk self-requested a review February 28, 2023 15:24
emilk
emilk approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looking forward to getting rid of ClassicTensor

crates/re_viewer/src/misc/caches/mod.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/misc/caches/mod.rs Outdated Show resolved Hide resolved
crates/re_viewer/src/ui/view_tensor/ui.rs Outdated Show resolved Hide resolved
@jleibs jleibs merged commit 5661806 into main Feb 28, 2023
@jleibs jleibs deleted the jleibs/tensor_view_without_classic branch February 28, 2023 18:11
emilk pushed a commit that referenced this pull request Mar 2, 2023
@jleibs @emilk
Convert view_tensor to use the new native Tensors (#1439)
89e09e1 
* Convert view_tensor to use the new native Tensors

* Limit F16 errors to the tensor module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
📉 performance Optimization, memory use, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tensor view is much slower than it should be
2 participants
@jleibs @emilk