Fix: don't create a dummy LogDb when opening the Rerun Menu #1440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
🪳 bug
teh-cmc
approved these changes
Feb 28, 2023
Comment on lines
+749
to
+753
| fn log_db_is_nonempty(&self) -> bool { | ||
| self.log_dbs | ||
| .get(&self.state.selected_rec_id) | ||
| .map_or(false, |log_db| !log_db.is_empty()) | ||
| } |
There was a problem hiding this comment.
is_nonempty feels very non-idiomatic and double-negativist... false means it's not non-empty?
There was a problem hiding this comment.
I agree, but I failed to find something better. Negating it we get something like log_db_is_empty_or_there_is_no_log_db
There was a problem hiding this comment.
I added an explanatory docstring that might help.
emilk
commented
Feb 28, 2023
emilk
added a commit
that referenced
this pull request
Mar 2, 2023
* Fix: don't create a dummy LogDb when opening the Rerun Menu * Add explanatory docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #914
Checklist