Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type signature for tensor names #1443

Merged
merged 2 commits into from Feb 28, 2023
Merged

Fix type signature for tensor names #1443

merged 2 commits into from Feb 28, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Feb 28, 2023

Following up on #631 fixed the type signature.

All other handling seemed to be done already:

import rerun as rr
import numpy as np

rr.init("tensor_test", spawn=True)

T = np.random.rand(10, 10, 10)
rr.log_tensor("tensor_test", T, names=["foo", None, "bar"])

image

Checklist

@jleibs jleibs added the 🐍 Python API Python logging API label Feb 28, 2023
@jleibs jleibs marked this pull request as ready for review February 28, 2023 15:45
@Wumpf Wumpf self-requested a review February 28, 2023 15:45
@jleibs jleibs merged commit 5c504fb into main Feb 28, 2023
@jleibs jleibs deleted the jleibs/log_tensor_names branch February 28, 2023 18:15
emilk pushed a commit that referenced this pull request Mar 2, 2023
* Fix type signature for tensor names

* Use Optional instead of |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐍 Python API Python logging API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants