Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the python job path filters so that wheels are always buildable #1452

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Remove the python job path filters so that wheels are always buildable #1452

merged 1 commit into from
Feb 28, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Feb 28, 2023 •
edited
Loading

Resolves: #1451

I ran into this issue as part of https://github.com/rerun-io/rerun/pull/1402/files but never ended up landing it.

Just add that isolated fix.

Checklist

@jleibs jleibs added the 🧑‍💻 dev experience developer experience (excluding CI) label Feb 28, 2023
@jleibs jleibs marked this pull request as ready for review February 28, 2023 18:54
Wumpf
Wumpf approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this causes CI (Python) / Python lints now always to be executed. But seems fast enough so I reckon that's alright.

@jleibs jleibs merged commit 22d2933 into main Feb 28, 2023
@jleibs jleibs deleted the jleibs/run_python_jobs branch February 28, 2023 21:28
emilk pushed a commit that referenced this pull request Mar 2, 2023
@jleibs @emilk
Remove the python job path filters (#1452)
33cb135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🧑‍💻 dev experience developer experience (excluding CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: the 🛞 build wheels label doesn't always work
2 participants
@jleibs @Wumpf