Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up convesions for color arrays #1454

Merged
merged 1 commit into from Feb 28, 2023
Merged

Speed up convesions for color arrays #1454

merged 1 commit into from Feb 28, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Feb 28, 2023 •
edited

Resolves: #1424

Uses column-wise numpy operations for re-packing bytes for color arrays.

On colmap this brings the per-cloud color conversion from 9ms -> 100us.

Checklist

@jleibs jleibs marked this pull request as ready for review February 28, 2023 19:59
@jleibs jleibs added 📉 performance Optimization, memory use, etc 🏹 arrow concerning arrow labels Feb 28, 2023
emilk
emilk approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@emilk emilk added the 🐍 Python API Python logging API label Feb 28, 2023
@jleibs jleibs merged commit 4513eb1 into main Feb 28, 2023
@jleibs jleibs deleted the jleibs/fast_color_array branch February 28, 2023 20:14
emilk pushed a commit that referenced this pull request Mar 2, 2023
@jleibs @emilk
Speed up convesions for color arrays (#1454)
8fd257d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🏹 arrow concerning arrow 📉 performance Optimization, memory use, etc 🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logging dense colored point clouds is too slow
2 participants
@jleibs @emilk