Delete ClassicTensor and cleanup #1456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleibs
force-pushed
the
jleibs/delete_classic_tensor
branch
from
31d2e5b
to
b12fe40
Compare
jleibs
added
🏹 arrow
jleibs
force-pushed
the
jleibs/delete_classic_tensor
branch
from
b12fe40
to
49be80e
Compare
jleibs
force-pushed
the
jleibs/delete_classic_tensor
branch
from
49be80e
to
6b1f111
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of: #1455
ClassicTensor is no longer used for anything.
First pass of removing it and cleaning up. Also migrated all the existing tests to use the new tensor <-> ndarray converters, which turned up an issue with converting from slices back to arrays.
Checklist