Log static re_renderer resource generation #1464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
commented
Mar 1, 2023
| @@ -46,6 +46,15 @@ pub struct TextureDesc { | |||
| pub usage: wgpu::TextureUsages, | |||
| } | |||
|
|
|||
| impl TextureDesc { | |||
| /// Copies the desc but changes the label. | |||
| pub fn with_label(&self, label: DebugLabel) -> Self { | |||
There was a problem hiding this comment.
This slipped in here by accident - I need it on my current work-stream but it has nothing to do with the pr description
But now it's here, so I'm keeping it :)
teh-cmc
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a situation where I needed to check whether the resource pool does it job (it did) and then noticed that unlike the dynamic resource pool, the static doesn't log resource creation!
Checklist