Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the prerelease before creating the new one #1485

Merged
merged 1 commit into from Mar 2, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Mar 2, 2023

Updating simply doesn't work the way we want. We know we get the behavior we want when the release is created, so just delete the old one and make a new one.

Switch back to using the same gh-action for prereleases as for main releases for consistency.

Checklist

@jleibs jleibs marked this pull request as ready for review March 2, 2023 17:08
@jleibs jleibs added the ⛴ release Related to shipping or publishing label Mar 2, 2023
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good comments ⭐⭐⭐

@emilk emilk merged commit e269138 into main Mar 2, 2023
@emilk emilk deleted the jleibs/delete_prerelease branch March 2, 2023 18:53
Wumpf pushed a commit that referenced this pull request Mar 7, 2023
# Conflicts:
#	.github/workflows/python.yml
Wumpf pushed a commit that referenced this pull request Mar 7, 2023
# Conflicts:
#	.github/workflows/python.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛴ release Related to shipping or publishing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants