[ci] Separate mac wheels & trigger wheel build from ui #1499
Conversation
|
Were you expecting this to run the wheel job? |
|
nope. didn't expect that. Fix under the way. And very nice that you found another issue as well!! |
| @@ -2,18 +2,23 @@ name: CI (Python) | |||
|
|
|||
| on: | |||
| pull_request: | |||
There was a problem hiding this comment.
| pull_request: | |
| pull_request: |
I think this line needs to go away to not trigger this job.
There was a problem hiding this comment.
it's still supposed to trigger it because of the linting that we always want to do. But then there is a check later down and I just learned how that was broken :)
Or rather I believe I know now why
Co-authored-by: Jeremy Leibs <jeremy@rerun.io>
| matrix=() | ||
|
|
||
| if [[ $TAGGED_OR_MAIN ]]; then | ||
| # MacOS build is really slow (>30 mins); uses up a lot of CI minutes | ||
| matrix+=('{"platform": "macos", "runs_on": "macos-latest"},') | ||
| fi | ||
| matrix+=('{"platform": "windows", "runs_on": "windows-latest-8-cores"},') | ||
| matrix+=('{"platform": "linux", "runs_on": "ubuntu-latest-16-cores", container: {"image": "rerunio/ci_docker:0.5"}}') | ||
| matrix+=('{"platform": "macos", "target": "x86_64-apple-darwin", "runs_on": "macos-latest"},') | ||
| matrix+=('{"platform": "macos", "target": "aarch64-apple-darwin", "runs_on": "macos-latest"},') | ||
| matrix+=('{"platform": "windows", "target": "x86_64-pc-windows-msvc", "runs_on": "windows-latest-8-cores"},') | ||
| matrix+=('{"platform": "linux", "target": "x86_64-unknown-linux-gnu", "runs_on": "ubuntu-latest-16-cores", container: {"image": "rerunio/ci_docker:0.5"}}') |
There was a problem hiding this comment.
This is a little different from how it normally looks:
https://github.com/rust-windowing/winit/blob/master/.github/workflows/ci.yml#L22-L43
There was a problem hiding this comment.
let's try this format instead, looks cleaner
There was a problem hiding this comment.
Yeah, now that it's not dynamically generated based on an env-variable, seems like we can clean it up.
There was a problem hiding this comment.
That's also something we might want to punt on though since this matrix-CI-builder mechanism has been working so far and restructuring the job graph is a good way to end up debugging job-graphs over the weekend.
workflow_dispatchfor ui controlled wheel publishing instead.The ui only works once this lands in main, so this is pretty much untested :(
I ensured using
actthat the yml is at least not broken.Might fix #1442
Checklist