Use cargo update -w instead of cargo check when prepping prerelease
#1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
We need to wait until all of the jobs are done here https://github.com/rerun-io/rerun/actions/runs/4325886388 buuuuuut it looks like it works fine and saves lots of time! (Linux is already through as of writing)
|
Before: After: 🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢🚢 |
emilk
reviewed
Mar 11, 2023
| @@ -185,7 +185,7 @@ jobs: | |||
| # This updates the cargo.lock file with the new version numbers and keeps the wheel build from failing | |||
| run: | | |||
| python3 scripts/version_util.py --patch_prerelease | |||
| cargo check | |||
| cargo update -w | |||
There was a problem hiding this comment.
It is nice to use the full names (--workspace) in checked in files. It helps readability quite a lot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Build wheels: https://github.com/rerun-io/rerun/actions/runs/4325886388