New time panel density graph #1557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
📺 re_viewer
emilk
commented
Mar 11, 2023
| "27.9 B/entry, spacing: 5M", | ||
| "35.5 B/entry, spacing: 8M", | ||
| "23.0 B/entry, spacing: 13M", | ||
| "9.6 B/entry, dense", |
There was a problem hiding this comment.
I switched to a faster but more memory-intense variant of re_int_histogram
emilk
commented
Mar 11, 2023
| let key = i as i64; | ||
| set.increment(key, 1); | ||
| #[cfg(test)] | ||
| mod tests { |
emilk
force-pushed
the
emilk/refactor-data-density-graph
branch
from
3ff826e
to
19e8db1
Compare
jleibs
approved these changes
Mar 13, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #619
The time panel used to be
O(N)over the number of log messages. With this PR it is nowO(log(N)).In order to accomplish this I decided to replace the "ball scatterer" visualization of the time panel with a brand new density graph. The end result is something that is much faster, and also looks much better.
Checklist