Better MsgId format #1566
Merged
Better MsgId format #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure I follow, looking at the
#1524 is specifically about the representation used when the |
Wumpf
reviewed
Mar 13, 2023
| impl std::fmt::Display for MsgId { | ||
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| write!(f, "{:x}", self.0.as_u128()) | ||
| write!(f, "{:032X}", self.0.as_u128()) |
There was a problem hiding this comment.
You can also switch Debug to only show the last 32 bits or so if you prefer
This now shows the same on both though. It shows the whole thing for both Debug & Display.
|
Yeah, I naively thought the store used the Anyway, this is an improvement imho |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can also switch
Debugto only show the last 32 bits or so if you prefer @teh-cmcChecklist