Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show log messages in egui toast notifications #1603

Merged
merged 10 commits into from Mar 20, 2023
Merged

Show log messages in egui toast notifications #1603

merged 10 commits into from Mar 20, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 16, 2023 •
edited

Show INFO, WARN, and ERROR in GUI as toast notifications. Otherwise users can easily miss important messages.

I've wanted to do this for a loooong time.

TODO: check if we both log and show notifications in some cases

Checklist

@emilk emilk added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself labels Mar 16, 2023
@emilk emilk marked this pull request as ready for review March 17, 2023 09:13
@emilk emilk mentioned this pull request Mar 20, 2023
Closed
6 tasks
@Wumpf Wumpf self-requested a review March 20, 2023 09:31
Wumpf
Wumpf approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried spammy message with newlines. Kinda works out well enough.
image

crates/re_log/src/channel_logger.rs Outdated Show resolved Hide resolved
@emilk emilk merged commit 3f367d4 into main Mar 20, 2023
@emilk emilk deleted the emilk/gui-logger branch March 20, 2023 10:40
Wumpf
Wumpf reviewed Mar 20, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much nicer silencing levels, thanks!!

@emilk emilk mentioned this pull request Mar 27, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilk @Wumpf