Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a patched wasm-bindgen-cli with fix for 2GiB bug #1605

Merged
merged 3 commits into from
Mar 17, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 17, 2023

Uses a version of wasm-bindgen-cli which is 0.2.84 plus rustwasm/wasm-bindgen#3310

See https://github.com/rerun-io/wasm-bindgen/commits/0.2.84-patch

Closes #1513

Checklist

@emilk emilk added the 🕸️ web regarding running the viewer in a browser label Mar 17, 2023
@emilk emilk marked this pull request as ready for review March 17, 2023 10:32
@jleibs
Copy link
Member

jleibs commented Mar 17, 2023

Need to update the Docker image as well -- taking care of that now.

@jleibs
Copy link
Member

jleibs commented Mar 17, 2023

Kicked off a wheel build: https://github.com/rerun-io/rerun/actions/runs/4447212228

@jleibs jleibs mentioned this pull request Mar 17, 2023
1 task
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using the generated wheels. Can confirm this fix works for me.

@emilk emilk merged commit 9ed0f27 into main Mar 17, 2023
@emilk emilk deleted the emilk/use-patched-wasm-bindgen-cli branch March 17, 2023 14:33
@emilk emilk changed the title Use a patched wasm-bindgen-cli with fix for 2GiB bug Use a patched wasm-bindgen-cli with fix for 2GiB bug Mar 27, 2023
@emilk emilk added the 💣 crash crash, deadlock/freeze, do-no-start label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💣 crash crash, deadlock/freeze, do-no-start 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasm_bindgen-caused web crash when using more than 2GiB of RAM
2 participants