Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nicer toast notifications #1621

Merged
merged 12 commits into from Mar 20, 2023
Merged

Nicer toast notifications #1621

merged 12 commits into from Mar 20, 2023

Conversation

emilk
Copy link
Member

@emilk emilk commented Mar 20, 2023 •
edited

The toast notifications have been improved in a few ways:

  • Line wrapping
  • Smaller text
  • No countdown-slider
  • Hover to keep it open
  • Click to close and copy text

Screen Shot 2023-03-20 at 14 57 10

(The "click-to-close" tooltip is only there because I'm hovering the last notification)

Checklist

@emilk emilk added ui concerns graphical user interface 📺 re_viewer affects re_viewer itself labels Mar 20, 2023
@Wumpf Wumpf self-requested a review March 20, 2023 16:13
Wumpf
Wumpf approved these changes Mar 20, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it!

@emilk emilk merged commit 4717659 into main Mar 20, 2023
@emilk emilk deleted the emilk/nicer_toasts branch March 20, 2023 16:40
@emilk emilk mentioned this pull request Mar 27, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
📺 re_viewer affects re_viewer itself ui concerns graphical user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@emilk @Wumpf