Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on serve exit, second attempt #1633

Merged
merged 2 commits into from Mar 21, 2023
Merged

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 21, 2023

Second attempt to #1613.

New commit is separate - passing shutdown bool around in order to not infect everything with tokio.
It seems we almost never need to hook it up, somewhat suspicious but I couldn't find any missing case.

Testing list. All of these were tested on 13aad68

  • cargo r -p rerun -- ../nyud.rrd
  • cargo run -p rerun --features web_viewer -- ../api_demo.rrd --web-viewer
  • cargo run -p re_web_viewer_server
  • cargo run -p api_demo -- --serve
  • python ./examples/python/api_demo/main.py --serve
  • python -m rerun --web-viewer ../objectron.rrd
  • python ./examples/python/tracking_hf_opencv/main.py
  • cargo run -p api_demo

Checklist

@emilk emilk added the 📺 re_viewer affects re_viewer itself label Mar 21, 2023
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution!

@emilk emilk merged commit 7c36951 into main Mar 21, 2023
@emilk emilk deleted the andreas/fix-crash-on-serve-exit2 branch March 21, 2023 10:36
@emilk emilk added the 💣 crash crash, deadlock/freeze, do-no-start label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💣 crash crash, deadlock/freeze, do-no-start 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants