Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix requiring requiring focus for shutdown via ctrl+c when starting viewer from command line #1646

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Fix requiring requiring focus for shutdown via ctrl+c when starting viewer from command line #1646

merged 1 commit into from
Mar 21, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 21, 2023

Checklist

@Wumpf Wumpf added 🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release labels Mar 21, 2023
@Wumpf Wumpf requested a review from emilk March 21, 2023 13:43
emilk
emilk approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@emilk emilk merged commit 1daccc1 into main Mar 21, 2023
@emilk emilk deleted the andreas/fix-ctrlc-focus-requirement branch March 21, 2023 14:24
@emilk emilk mentioned this pull request Mar 27, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working 📺 re_viewer affects re_viewer itself 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Wumpf @emilk