Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when trying to listen on a taken TCP port #1650

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Fix crash when trying to listen on a taken TCP port #1650

merged 3 commits into from
Mar 21, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 21, 2023

Fixes #1644

Checklist

@Wumpf Wumpf added 🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release labels Mar 21, 2023
@jleibs jleibs self-requested a review March 21, 2023 14:13
jleibs
jleibs requested changes Mar 21, 2023
View reviewed changes
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still opening a second window.

jleibs
jleibs approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@jleibs jleibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed as working.

@jleibs jleibs merged commit 9ef34dd into main Mar 21, 2023
@jleibs jleibs deleted the andreas/fix-listen-failure-causing-crash branch March 21, 2023 16:06
@emilk emilk mentioned this pull request Mar 27, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jleibs jleibs jleibs approved these changes

Assignees
No one assigned
Labels
🪳 bug Something isn't working 🦟 regression A thing that used to work in an earlier release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rerun ends up with an orphaned window when it fails to bind to a tcp port
2 participants
@Wumpf @jleibs