Warn when most of the RAM has been used up by Rerun #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unless the `--memory-limit` is already set, we now warn and suggest setting it when Rerun is using 75% of all available RAM by itself.
teh-cmc
approved these changes
Mar 21, 2023
|
A bit finicky on Linux since RSS count is disabled but eh 🤷♂️ |
|
confirmed limit printing to be working on windows! Anything you did to test hitting the limit? |
|
@Wumpf running |
|
works! |
This was referenced Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless the
--memory-limitis already set, we now warn and suggest setting it when Rerun is using 75% of all available RAM by itself.Tested on:
The easiest to test is to run with
RUST_LOG=debugand se what limit is printed out.Checklist