Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make log_point more forgiving and update docstring #1663

Merged
merged 1 commit into from Mar 21, 2023
Merged

Make log_point more forgiving and update docstring #1663

merged 1 commit into from Mar 21, 2023

Conversation

jleibs
Copy link
Member

@jleibs jleibs commented Mar 21, 2023 •
edited

Resolves: #1642

Checklist

@jleibs jleibs marked this pull request as ready for review March 21, 2023 20:15
@jleibs jleibs added the 🐍 Python API Python logging API label Mar 21, 2023
Wumpf
Wumpf approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense! but I also thought at some point we wanted to remove singular element logging (or did we decide against that again? not sure)

@jleibs
Copy link
Member Author

jleibs commented Mar 21, 2023

Yeah -- as long as we have it having it behave consistently seems worthwhile though.

@jleibs jleibs merged commit f5de99e into main Mar 21, 2023
@jleibs jleibs deleted the jleibs/log_point_checks branch March 21, 2023 22:23
@emilk emilk mentioned this pull request Mar 27, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wumpf Wumpf Wumpf approved these changes

Assignees
No one assigned
Labels
🐍 Python API Python logging API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

log_point expected shape and error on wrong shape
2 participants
@jleibs @Wumpf