Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wgpu to v0.15.3, fixing meshes on Windows Chrome #1682

Merged
merged 3 commits into from Mar 23, 2023

Conversation

Wumpf
Copy link
Member

@Wumpf Wumpf commented Mar 23, 2023

Fixes #1620 (meshes don't show up on windows chrome)
Removes need for alpha-to-coverage workaround.

Tested raw_mesh & colmap on Windows Firefox & Chrome.

Yes, the v0.15.3 tag of wgpu is a range of versions of its different crates, ironically none of which is marked with 0.15.3 due to a previous publishing mistake

Checklist

cargo update -p wgpu
cargo update -p wgpu-hal
cargo update -p wgpu-core
cargo update -p wgpu-types
@Wumpf Wumpf added 🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser labels Mar 23, 2023
@emilk
Copy link
Member

emilk commented Mar 23, 2023

You also need to the version in Cargo.toml, otherwise these fixes won't make it to users of our crates unless they manually run cargo update.

@Wumpf
Copy link
Member Author

Wumpf commented Mar 23, 2023

@emilk I reckon I need to drag in wgpu-hal 0.15.4 explicitly now as I've done it now?

Copy link
Member

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup - that looks right!

@emilk emilk merged commit 0f2569d into main Mar 23, 2023
17 checks passed
@emilk emilk deleted the andreas/wgpu-patch-update branch March 23, 2023 14:18
@emilk emilk changed the title Update wgpu to v0.15.3 Update wgpu to v0.15.3, fixing meshes on Chrome Mar 27, 2023
@emilk emilk changed the title Update wgpu to v0.15.3, fixing meshes on Chrome Update wgpu to v0.15.3, fixing meshes on Windows Chrome Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪳 bug Something isn't working 🕸️ web regarding running the viewer in a browser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meshes don't show up on Chrome on Windows
2 participants