Improve ui for tensors and color map selection #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
added
ui
teh-cmc
approved these changes
Mar 23, 2023
Comment on lines
21
to
25
| /// Number of bytes in the buffer. | ||
| #[inline] | ||
| pub fn len(&self) -> usize { | ||
| self.0.len() | ||
| } |
There was a problem hiding this comment.
I'd just call it num_bytes, len is so overloaded at this point...
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show all details about a tensor, including its meaning,
meterand encoding:Also simplify the color maps selection for backprojected depth. Previously there was a superfluous checkbox gatekeeping the selection, even though there was always a color map (it just defaulted to gray). Speaking of: I changed the default to Turbo:
Checklist